autopkg / timsutton-recipes

AutoPkg recipes
16 stars 37 forks source link

RE: timsutton-recipes/Figure53/QLab3.munki.recipe #52

Closed elflames closed 4 years ago

elflames commented 6 years ago

It appears when the Qlab3.download.recipe was updated with the addition of /Applications the munki recipe broke when trying to do a munkiimport as there was no application anymore at the root of the DMG. Munkimport is failing with "Error in local.munki.CDU-QLab3: Processor: MunkiImporter: Error: creating pkginfo for /Users/autopkgr/Library/AutoPkg/Cache/local.munki.CDU-QLab3/QLab3.dmg failed: Could not find a supported installer item in /Users/autopkgr/Library/AutoPkg/Cache/local.munki.CDU-QLab3/QLab3.dmg!"

by adding /Applications to the dmg_root key munkiimport works again.

Figured I would open this issue, incase this was a slight oversight?

cheers for all your goodies over the years mate.

timsutton commented 6 years ago

Sounds like you've identified the issue, thanks! Would you be able to contribute a working PR?

JMichaelAdams commented 6 years ago

I was getting the same error as elflames and adding /Applications to the dmg_root resolved my issue as well :

The following recipes failed: /Users/bs_autopkg/Library/AutoPkg/RecipeOverrides/QLab3.munki.recipe Error in local.munki.QLab3: Processor: MunkiImporter: Error: creating pkginfo for /Users/bs_autopkg/Library/AutoPkg/Cache/local.munki.QLab3/QLab.dmg failed: Could not find a supported installer item in /Users/bs_autopkg/Library/AutoPkg/Cache/local.munki.QLab3/QLab.dmg!

`<?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">

Description Downloads the latest version of QLab 3 and imports into Munki. Identifier com.github.timsutton.munki.qlab3 Input NAME QLab3 MUNKI_REPO_SUBDIR apps/%NAME% pkginfo catalogs testing description QLab provides live show control for your Mac. Create media designs for theatre, dance, composition, installation, and more. Play back audio, video, and MIDI from a single workspace. display_name QLab 3 name %NAME% unattended_install MinimumVersion 0.2.0 ParentRecipe com.github.timsutton.download.qlab3 Process Processor MunkiPkginfoMerger Processor DmgCreator Arguments dmg_root %RECIPE_CACHE_DIR%/%NAME%/Applications dmg_path %RECIPE_CACHE_DIR%/%NAME%.dmg Arguments pkg_path %dmg_path% repo_subdirectory %MUNKI_REPO_SUBDIR% Processor MunkiImporter

`

timsutton commented 6 years ago

Thanks for confirming @nescom-it! Would anyone be willing to submit those changes as a PR so that we can merge a fix?

Tangentially, is Figure53 still supporting Qlab3? Been a while since I’ve worked with it and before I left my workplace which used it we had moved onto Qlab4.

JMichaelAdams commented 6 years ago

I have created a PR for this fix. Figure 53 is still supporting Qlab 3 as of February 5, 2018. Thanks again.

timsutton commented 4 years ago

Closed in #58.