search

autorope / donkeycar

Open source hardware and software platform to build a small scale self driving car.
http://www.donkeycar.com
MIT License
3.13k stars 1.29k forks source link

Fixing setup.py for jetson #1135

Closed DocGarbanzo closed 1 year ago

DocGarbanzo commented 1 year ago

Remove albumentations from jetson setup and move pyyaml into the required section, so it also installs on RPi. Also bump version.

Ezward commented 1 year ago

Should we just replace the two augmentations with our own code? One is guassian blur and we already have that in https://github.com/autorope/donkeycar/blob/1398eec8309499c4d54fc45d510348bcb819daff/donkeycar/parts/cv.py#L323 and the other is a randomized brightness/contrast that we could easily implement.

I added an issue for this; https://github.com/autorope/donkeycar/issues/1136

Ezward commented 1 year ago

However, for now this is a good enough fix. Thanks @DocGarbanzo

DocGarbanzo commented 1 year ago

Should we just replace the two augmentations with our own code? One is guassian blur and we already have that in

https://github.com/autorope/donkeycar/blob/1398eec8309499c4d54fc45d510348bcb819daff/donkeycar/parts/cv.py#L323 and the other is a randomized brightness/contrast that we could easily implement.

I added an issue for this; #1136

Yes, I was thinking the exact same thing. I want to google around a bit if there are other augmentations that might be useful for use, but for blur / brightness we can just use the one you already created.