autorope / donkeycar

Open source hardware and software platform to build a small scale self driving car.
http://www.donkeycar.com
MIT License
3.17k stars 1.3k forks source link

Columns and DataType Not Explicitly Set on line 112 of database.py #1137

Open CodeSmileBot opened 1 year ago

CodeSmileBot commented 1 year ago

Hello!

I found an AI-Specific Code smell in your project. The smell is called: Columns and DataType Not Explicitly Set

You can find more information about it in this paper: https://dl.acm.org/doi/abs/10.1145/3522664.3528620.

According to the paper, the smell is described as follows:

Problem If the columns are not selected explicitly, it is not easy for developers to know what to expect in the downstream data schema. If the datatype is not set explicitly, it may silently continue the next step even though the input is unexpected, which may cause errors later. The same applies to other data importing scenarios.
Solution It is recommended to set the columns and DataType explicitly in data processing.
Impact Readability

Example:


### Pandas Column Selection
import pandas as pd
df = pd.read_csv('data.csv')
+ df = df[['col1', 'col2', 'col3']]

### Pandas Set DataType
import pandas as pd
- df = pd.read_csv('data.csv')
+ df = pd.read_csv('data.csv', dtype={'col1': 'str', 'col2': 'int', 'col3': 'float'})

You can find the code related to this smell in this link: https://github.com/autorope/donkeycar/blob/c0d4eb310b4aab4915a655f7545a2aa8bf983e50/donkeycar/pipeline/database.py#L102-L122.

I also found instances of this smell in other files, such as:

File: https://github.com/autorope/donkeycar/blob/master/donkeycar/management/base.py#L333-L343 Line: 338 File: https://github.com/autorope/donkeycar/blob/master/donkeycar/management/base.py#L480-L490 Line: 485 File: https://github.com/autorope/donkeycar/blob/master/donkeycar/management/base.py#L482-L492 Line: 487 File: https://github.com/autorope/donkeycar/blob/master/donkeycar/management/graph.py#L160-L170 Line: 165 File: https://github.com/autorope/donkeycar/blob/master/donkeycar/management/kivy_ui.py#L627-L637 Line: 632 .

I hope this information is helpful!