Move away from DRIVE_TRAIN_TYPE and HAVE_

autorope / donkeycar

Open source hardware and software platform to build a small scale self driving car.

http://www.donkeycar.com

MIT License

3.16k stars 1.3k forks source link

Move away from DRIVE_TRAIN_TYPE and HAVE_ #615

Closed wallarug closed 3 years ago

wallarug commented 4 years ago

Can we please pick one standard?

Having both is causing some issues for people as it is counterproductive to have to turn something on twice.

My recommendation would be to use only two variables throughout and remove all the HAVE_BOARD ones.

CONTROLLER_TYPE="" DRIVE_TRAIN_TYPE=""

tawnkramer commented 4 years ago

the have sombrero doesn't change the drive train type

DocGarbanzo commented 3 years ago

@wallarug - is this still an active problem?

zlite commented 3 years ago

Yes, this is still suboptimal. I agree with @wallarug that we should define inputs (controller type) and outputs (drive trains) and that no other board definition should be required. In this case "HAVE_ROBOHAT" is redundant and should be removed in the code and replaced with either "controller_type" or "drive_train_type" as appropriate

zlite commented 3 years ago

Fixed with this PR: https://github.com/autorope/donkeycar/pull/851