autorope / donkeycar

Open source hardware and software platform to build a small scale self driving car.
http://www.donkeycar.com
MIT License
3.13k stars 1.29k forks source link

Feature: add CODEOWNERS files so that it makes easier to assign reviewers. #618

Open nvtkaszpir opened 4 years ago

nvtkaszpir commented 4 years ago

Notice, this requires some paid GitHub service, unless we could find some github bot that could help with labeling (there are some).

I believe the project would benefit if there was CODEOWNERS file with rules about who can review what. Example - certian modules are known to be developed by certain commiters (for example RoboHat -> @wallarug, @rahul about recent additions to TF models, some other people for docs and so on....)

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

May be especially useful before 4.0 branch is in full operation.

What do you think? @wroscoe @tawnkramer @tikurahul (who else?)

wallarug commented 4 years ago

I like this idea in general, however, not sure if supports the open source nature of the Donkey Car Project.

It makes sense for ensuring that hardware support is maintained.

wallarug commented 3 years ago

Hey @nvtkaszpir did you end up implementing this?

nvtkaszpir commented 3 years ago

@wallarug see the linked PR?