Incorrect PS4 gamepad keycodes in "controller.py"

autorope / donkeycar

Open source hardware and software platform to build a small scale self driving car.

http://www.donkeycar.com

MIT License

3.16k stars 1.3k forks source link

Open TCIII opened 3 years ago

TCIII commented 3 years ago

I have found an error in the master branch "controller.py" part. At the bottom of the "class PS4JoyStick(Joystick)": 0x13a : 'L3', 0x13b : 'R3',

0x13a : 'share', 0x13b : 'options',

Which keycodes are correct for these four buttons?

cfox570 commented 3 years ago

I found the following works: 0x13d : 'L3' 0x13e : 'R3'

The codes for share and options are correct.

Ezward commented 1 year ago

Note that we are going to refactor the game controller system, so we can deal with this, if it is still an issue, then. https://github.com/autorope/donkeycar/issues/1097