autosarzs / Dev

Development AUTOSAR
Mozilla Public License 2.0
50 stars 21 forks source link

Can_write_Fix #42

Closed Muhammed-ELGendy closed 4 years ago

Muhammed-ELGendy commented 4 years ago

1- Det_ReportError function is left as a comment in the if statement and its branches, it should not be left as a comment 2- ui32Base , hth_index , Hth_count , Hoh_count and real_hwObjectId are declared but not defined with their declaration . Although it is defined inside if statements and for loop (Not a good practice). 3- Integrate NUM_OF_HOH definition by deleting CAN_HOH_NUMBER , then Casting it to uint8 4- Make #endif correct as it is used in a wrong way 5- STD_ON is defined in Std_Types.h , While STD_ON is used before including Std_Types.h 6- [SWS_Can_00275] The function Can_Write shall be non-blocking, while it is blocking to check CANIF1CRQ register