search

autosarzs / Dev

Development AUTOSAR
Mozilla Public License 2.0
52 stars 19 forks source link

CanDev_SetControllerModeFix #46

Closed AAdelBayoumi closed 4 years ago

AAdelBayoumi commented 4 years ago

1.Check for the module init state not controller: [SWS_Can_00198] if the module is not yet initialized, the function Can_SetControllerMode shall raise development error CAN_E_UNINIT and return E_NOT_OK.

  1. when request is accepted the function should return E_OK

  2. Code duplication for duplications

ahmedwahdan commented 4 years ago

those two points are not resolved in the commit.

  1. when request is accepted the function should return E_OK
  2. Code duplication for duplication