autosarzs / Dev

Development AUTOSAR
Mozilla Public License 2.0
52 stars 19 forks source link

Can main function write fixed #50

Closed Muhammed-ELGendy closed 4 years ago

Muhammed-ELGendy commented 4 years ago

1- [ECUC_Can_00318] CanTxProcessing is a parameter in CanController struct , I added CanTxProcessing inside CanController struct. -->> Done 2- Using if statement for each controller ( to check for CONTROLLER_0/1_ID in the second if statement inside the loop, POLLING and MIXED or CAN_CONTROLLER_ACTIVATION ) is not generic . what if we have 5 or more controllers ?! To make it more generic , I have edited it using array. -->> Done 3- NUM_OF_HOH should be declared by casting to uint8 -->> Done 4- In the second if statement inside the loop (left operand), &Global_Config is a wrong access. It should be written without ampersand operator according to Global_Config declaration. -->> Done 5- In the second if statement inside the loop (left operand), CanControllerRef is accessed incorrectly as an array. CanControllerRef is a CanController pointer. In contrast, CanControllerRef is defined as an object of struct in Can_Pbcfg.c -->> Done

ahmedwahdan commented 4 years ago

All the commits are empty!

Muhammed-ELGendy commented 4 years ago

All the commits are empty!

All the commits are pushed

ahmedwahdan commented 4 years ago

This code doesn't compile.