search

autosarzs / Dev

Development AUTOSAR
Mozilla Public License 2.0
50 stars 21 forks source link

Can_Write_Fix PullReq #53

Closed Muhammed-ELGendy closed 4 years ago

Muhammed-ELGendy commented 4 years ago

1- Det_ReportError function is called not left as a comment. 2- ui32Base , hth_index , Hth_count , Hoh_count and real_hwObjectId are defined with zeros not declared only. 3- Made #endif correct as it was used in a wrong way. 4- including Std_Types.h before using STD_ON which is defined in Std_Types.h , While STD_ON was used in Can_Cfg.h before including Std_Types.h . 5- Edited the blocking loop problem, [SWS_Can_00275] The function Can_Write shall be non-blocking, while it is blocking to check CANIF1CRQ register. 6- Edited the code to perform no actions if the hardware transmit object is busy and return CAN_BUSY as [SWS_Can_00213] says.

ahmedwahdan commented 4 years ago

You are pushing these changes to Can_MainFunction_Write_Fix branch, you should push to DevCAN

Muhammed-ELGendy commented 4 years ago

@ahmedwahdan I pushed to Can_MainFunction_Write_Fix branch, but I meant to merge to DevCAN .