search

autosportlabs / STM32Fx_FreeRTOS_Base

FreeRTOS starter project for STM32 F1 and F4 microcontrollers.
8 stars 3 forks source link

F0 usart #6

Closed Jeff-Ciesielski closed 9 years ago

Jeff-Ciesielski commented 9 years ago

This patch set adds an stm32f0 interrupt driven usart driver, as well as a serial command shell and stm32f0 example

vadimplobanov commented 9 years ago

Looks awesome! Most of the comments are for tiny and very bikesheddy stuff. :)

Jeff-Ciesielski commented 9 years ago

Thanks for taking the time to review. A lot of the inconsistency is due to both the usart and shell being pulled from other past projects, but I'm glad you're calling out what you see, I'd rather have it all fit together nicely :)

vadimplobanov commented 9 years ago

No problem. I erred on the side of providing more comments rather than fewer, figuring you can ignore the really nit-picky stuff if the code looks better without.