autostep / AutoStep

AutoStep Testing Framework - Core Libraries and Components
MIT License
22 stars 1 forks source link

Stuff1 #45

Closed SimonCropp closed 4 years ago

SimonCropp commented 4 years ago

mostly whitespace to reduce noise in future PRs

alistairjevans commented 4 years ago

Thanks @SimonCropp!

I was unsure whether to enable nullable constraints globally, due to the extra markers required in test projects, but perhaps having to explicitly send null is better?

As for the whitespace, there are a couple of places where end-of-line whitespace remains important, mostly inside literal code blocks used for language tests, because the test language needs to be able to tokenise whitespace, so I may have to leave that whitespace behind.

SimonCropp commented 4 years ago

i left some whitespace in tests. did i miss some?

SimonCropp commented 4 years ago

seems i have fixed the warnings?

SimonCropp commented 4 years ago

this will need a squash on merge

alistairjevans commented 4 years ago

Yes, all looks good to me now.

Thanks for sticking with the nullable changes, I know they can be a pain.

You happy for me to merge this?

SimonCropp commented 4 years ago

yep ready to merge