Closed SimonCropp closed 4 years ago
Thanks @SimonCropp!
I was unsure whether to enable nullable constraints globally, due to the extra markers required in test projects, but perhaps having to explicitly send null is better?
As for the whitespace, there are a couple of places where end-of-line whitespace remains important, mostly inside literal code blocks used for language tests, because the test language needs to be able to tokenise whitespace, so I may have to leave that whitespace behind.
i left some whitespace in tests. did i miss some?
seems i have fixed the warnings?
this will need a squash on merge
Yes, all looks good to me now.
Thanks for sticking with the nullable changes, I know they can be a pain.
You happy for me to merge this?
yep ready to merge
mostly whitespace to reduce noise in future PRs