search

autotelik / datashift

Full Excel/CSV Import/Export facilities for Rails
http://www.autotelik.co.uk
Other
136 stars 75 forks source link

Regression on image loading when using master #14

Closed ebreton closed 12 years ago

ebreton commented 12 years ago

Hello Tom,

I gave a new try on my file with multiple sub-categories of same name.

I have the following error : 

$ bundle exec thor datashift:spree:products -i Omega_checked.csv 
/home/emb/.../bundler/gems/datashift-6b6bd8c89874/lib/loaders/paperclip/image_loader.rb:14:in `<module:ImageLoading>': uninitialized constant DataShift::Paperclip (NameError)
    from /home/emb/.../bundler/gems/datashift-6b6bd8c89874/lib/loaders/paperclip/image_loader.rb:12:in `<module:DataShift>'
    from /home/emb/.../bundler/gems/datashift-6b6bd8c89874/lib/loaders/paperclip/image_loader.rb:10:in `<top (required)>'
    from /home/emb/.../gems/polyglot-0.3.3/lib/polyglot.rb:63:in `require'
    from /home/emb/.../gems/polyglot-0.3.3/lib/polyglot.rb:63:in `require'
    from /home/emb/.../bundler/gems/datashift-6b6bd8c89874/lib/loaders/spree/product_loader.rb:11:in `<top (required)>'
    from /home/emb/.../gems/polyglot-0.3.3/lib/polyglot.rb:63:in `require'
    from /home/emb/.../gems/polyglot-0.3.3/lib/polyglot.rb:63:in `require'
    from /home/emb/.../bundler/gems/datashift-6b6bd8c89874/lib/thor/spree/products_images.thor:36:in `products'
    from /home/emb/.../gems/thor-0.16.0/lib/thor/task.rb:27:in `run'
    from /home/emb/.../gems/thor-0.16.0/lib/thor/invocation.rb:120:in `invoke_task'
    from /home/emb/.../gems/thor-0.16.0/lib/thor.rb:275:in `dispatch'
    from /home/emb/.../gems/thor-0.16.0/lib/thor/base.rb:425:in `start'
    from /home/emb/.../gems/thor-0.16.0/lib/thor/runner.rb:36:in `method_missing'
    from /home/emb/.../gems/thor-0.16.0/lib/thor/task.rb:29:in `run'
    from /home/emb/.../gems/thor-0.16.0/lib/thor/task.rb:126:in `run'
    from /home/emb/.../gems/thor-0.16.0/lib/thor/invocation.rb:120:in `invoke_task'
    from /home/emb/.../gems/thor-0.16.0/lib/thor.rb:275:in `dispatch'
    from /home/emb/.../gems/thor-0.16.0/lib/thor/base.rb:425:in `start'
    from /home/emb/.../gems/thor-0.16.0/bin/thor:6:in `<top (required)>'
    from /home/emb/.../bin/thor:19:in `load'
    from /home/emb/.../bin/thor:19:in `<main>'
    from /home/emb/.../bin/ruby_noexec_wrapper:14:in `eval'
    from /home/emb/.../bin/ruby_noexec_wrapper:14:in `<main>'

The file was correctly imported with stable version. Please, tell me which information you need, if you need any more.

Cheers, Manu

autotelik commented 12 years ago

hi there .. thanks for the feedback .. is this via the gem or via the latest in github

bummer as I got all the specs passing !

From: Manu notifications@github.com To: autotelik/datashift datashift@noreply.github.com Sent: Saturday, 15 September 2012, 17:10 Subject: [datashift] Regression on image loading when using master (#14)

Hello Tom, I gave a new try on my file with multiple sub-categories of same name. I have the following error : $ bundle exec thor datashift:spree:products -i Omega_checked.csv /home/emb/.../bundler/gems/datashift-6b6bd8c89874/lib/loaders/paperclip/image_loader.rb:14:in <module:ImageLoading>': uninitialized constant DataShift::Paperclip (NameError) from /home/emb/.../bundler/gems/datashift-6b6bd8c89874/lib/loaders/paperclip/image_loader.rb:12:inmodule:DataShift' from /home/emb/.../bundler/gems/datashift-6b6bd8c89874/lib/loaders/paperclip/image_loader.rb:10:in <top (required)>' from /home/emb/.../gems/polyglot-0.3.3/lib/polyglot.rb:63:inrequire' from /home/emb/.../gems/polyglot-0.3.3/lib/polyglot.rb:63:in require' from /home/emb/.../bundler/gems/datashift-6b6bd8c89874/lib/loaders/spree/product_loader.rb:11:in<top (required)>' from /home/emb/.../gems/polyglot-0.3.3/lib/polyglot.rb:63:in require' from /home/emb/.../gems/polyglot-0.3.3/lib/polyglot.rb:63:inrequire' from /home/emb/.../bundler/gems/datashift-6b6bd8c89874/lib/thor/spree/products_images.thor:36:in products' from /home/emb/.../gems/thor-0.16.0/lib/thor/task.rb:27:inrun' from /home/emb/.../gems/thor-0.16.0/lib/thor/invocation.rb:120:in invoke_task' from /home/emb/.../gems/thor-0.16.0/lib/thor.rb:275:indispatch' from /home/emb/.../gems/thor-0.16.0/lib/thor/base.rb:425:in start' from /home/emb/.../gems/thor-0.16.0/lib/thor/runner.rb:36:inmethod_missing' from /home/emb/.../gems/thor-0.16.0/lib/thor/task.rb:29:in run' from /home/emb/.../gems/thor-0.16.0/lib/thor/task.rb:126:inrun' from /home/emb/.../gems/thor-0.16.0/lib/thor/invocation.rb:120:in invoke_task' from /home/emb/.../gems/thor-0.16.0/lib/thor.rb:275:indispatch' from /home/emb/.../gems/thor-0.16.0/lib/thor/base.rb:425:in start' from /home/emb/.../gems/thor-0.16.0/bin/thor:6:in<top (required)>' from /home/emb/.../bin/thor:19:in load' from /home/emb/.../bin/thor:19:in

' from /home/emb/.../bin/ruby_noexec_wrapper:14:in eval' from /home/emb/.../bin/ruby_noexec_wrapper:14:in
' The file was correctly imported with stable version. Please, tell me which information you need, if you need any more. Cheers, Manu — Reply to this email directly or view it on GitHub.

ebreton commented 12 years ago

via the latest in github. The gem is working fine

/Manu

autotelik commented 12 years ago

ah ok. pheew ! :-)

I just started to add new paperclip loader for working with things like spree_digital but I haven't yet added specs for the thor tasks so probably stuff broken.

thanks for the feedback tom

From: Manu notifications@github.com To: autotelik/datashift datashift@noreply.github.com Cc: tom statter github@autotelik.co.uk Sent: Saturday, 15 September 2012, 17:54 Subject: Re: [datashift] Regression on image loading when using master (#14)

via the latest in github. The gem is working fine /Manu — Reply to this email directly or view it on GitHub.

ebreton commented 12 years ago

The thing is that if I use the gem 0.9.0… the import works but without the fix for sub categories...

I have gem 'datashitf' in my Gemfile

Should I point something else ?

Le 15 sept. 2012 à 19:02, tom statter notifications@github.com a écrit :

ah ok. pheew ! :-)

I just started to add new paperclip loader for working with things like spree_digital but I haven't yet added specs for the thor tasks so probably stuff broken.

thanks for the feedback tom

From: Manu notifications@github.com To: autotelik/datashift datashift@noreply.github.com Cc: tom statter github@autotelik.co.uk Sent: Saturday, 15 September 2012, 17:54 Subject: Re: [datashift] Regression on image loading when using master (#14)

via the latest in github. The gem is working fine /Manu — Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub.

ebreton commented 12 years ago

All is fine with your last commit (930bc35b352556994ec6c7bb0def39ed5b80adab). The sub-categories are properly created and filled with products

Many Thanks ! Manu

autotelik commented 12 years ago

no worries !

thanks for your feedback and helping test things out in the real world

From: Manu notifications@github.com To: autotelik/datashift datashift@noreply.github.com Cc: tom statter github@autotelik.co.uk Sent: Sunday, 16 September 2012, 17:07 Subject: Re: [datashift] Regression on image loading when using master (#14)

All is fine with your last commit (930bc35). The sub-categories are properly created and filled with products Many Thanks ! Manu — Reply to this email directly or view it on GitHub.