search

autotest / autotest-client-tests

Autotest client tests
Other
29 stars 84 forks source link

cgroup_test: Add a test for memory resource control #26

Closed leonstack closed 10 years ago

leonstack commented 11 years ago

1.Set limit memory to 60M 2.Execute a process in cgroup, malloc 50M, and confirm the memory information in cgroup 3.Execute a process in cgroup, malloc 70M, and confirm the memory information in cgroup

Signed-off-by: Li Yang liyang.fnst@cn.fujitsu.com

leonstack commented 11 years ago

@ldoktor @lmr Another test for memory resource control test. If you have time, please review this one:)

leonstack commented 11 years ago

@ldoktor If you have time.please review this simple pullreq.

ldoktor commented 11 years ago

Hi Li, sorry for a late review. I found few issues according this test. Please put the C code outside the python code. It's not a good practice to mix them. Additionally please take a look on the few typo/modifications I stated there.

The whole test works fine.

ruda commented 10 years ago

I agree with @ldoktor , it's not good practice indeed. So, can we advance in this pull request?

leonstack commented 10 years ago

@ldoktor @ruda Sorry for my late response...I will fix the issues you mentioned next week, this week I have to do some other busy work :(

ldoktor commented 10 years ago

np., we all have other things to do...

leonstack commented 10 years ago

@ldoktor Thanks for your suggestion, now I fixed them and separate C file from code.

lmr commented 10 years ago

Rebased and pushed to next, thanks!