lmr
commented
7 years ago Some comments on recent commits:
1) Back when you guys had a huge backlog we discussed it was sort of OK to have one big commit with the title linux_tools: Fixes for integration bugs. Now, every commit after that having the same title is not OK. Therefore, you should now start to separate commits per submodule being modified, with a better explanation in the commit title.
2) Therefore, you should pick the contents of patches 1 and 2, and then split the changes per module, and resubmit the Pull Request. You even have the explanations for each module you are changing in the commits' bodies.
So the idea here is, let's try to make a clean and readable git commit history. One exception we made to try to alleviate your team's backlog does not mean we should keep with the bad practices.
ramyabs
Incorporated the changes suggested in pull request #85 crontab/pax/avahi_autoipd : Updated the test path in control file,also tests failed because import of some of the modules were missing,so added the same in .py files . gpgme_test/pango : Fixed in .sh wrapper script(as we had used variable in sed command,but it was not handled properly,hence the wrong path was updated in respective files ) pexpect_test : One of the test patch was not applied due to which tests were failing,hence updated pexpect_test.py wrapper to apply patch before triggering the tests .
Signed-off-by:ramyabsramya@linux.vnet.ibm.com Tested-by:ramyabswramya@linux.vnet.ibm.com