cevich commented 10 years ago

On 11/05/2013 03:48 PM, Dongsheng Yang wrote:

On 11/04/2013 07:45 PM, John Ferlan wrote:
   5 iface_trans
Not quite sure yet, each failure is different... It's getting too late for me to look further tonight. I got all pass in my test of iface_trans, maybe there is something required by it.

Environment:

Lenovo T530, 4 CPUs (dual-core + HT), 8G ram
Latest hand-build of libvirt (almost 1.1.4)
Running as root, SELinux in permissive mode
Default bridge mode networking
Default JeOS 19 x86_64 guest

cevich commented 10 years ago

On 11/05/2013 11:31 AM, John Ferlan wrote:

Will look/retest again.

Thanks, assigning to you then...

chuanchang commented 10 years ago

@jferlan, @cevich, could you show which case is failed? it's okay for me on RHEL6.5 and RHEL7.0, so I want to know your host test ENV(Fedora19?libvirt upstream?) . In addition, it's an expected error if you haven't installed netcf and its library on the host. Anyway, thanks for checking the case.

jferlan commented 10 years ago

I have F19 and upstream libvirt. If 'netcf' is expected then I would think there would need to be a search for it and cause a SKIP if what you expect isn't found.

FWIW:

yum list installed | grep netcf

netcf-devel.x86_64 0.2.3-4.fc19 installed netcf-libs.x86_64 0.2.3-4.fc19 installed

Of the 6 tests only 'type_specific.virsh.iface_trans.negative_testing.exist_transaction' passes.

I'm getting the following in the debug.log output (I'll uses ellipses to skip some stuff)

... Usage: /etc/rc.d/init.d/netcf-transaction {change-begin|change-commit|change-rollback|snapshot-dir|start|stop|status|restart|condrestart|try-restart|reload|force-reload} Usage: /etc/rc.d/rc0.d/K91netcf-transaction {change-begin|change-commit|change-rollback|snapshot-dir|start|stop|status|restart|condrestart|try-restart|reload|force-reload} (the above repeated 6 times) There is an open transaction

.... FAIL type_specific.virsh.iface_trans.positive_testing.open_commit_transaction -> TestFail: Failed to create snapshot for interface ... Test parameters: 03:47:18 DEBUG| _name_map_file = {'tests.cfg': 'libvirt_quick', 'machines.cfg': 'i440fx', 'subtests.cfg': '(subtest=type_specific).(subtest=virsh).(subtest=iface_trans).positive_testing.open_rollback_transaction', 'guest-hw.cfg': 'no_glusterfs_support.no_9p_export.smallpages.no_pci_assignable.qcow2.virtio_blk.smp2.virtio_net', 'guest-os.cfg': 'Linux.JeOS.19.x86_64'} 03:47:18 DEBUG| _short_name_map_file = {'tests.cfg': 'libvirt_quick', 'machines.cfg': 'i440fx', 'subtests.cfg': 'type_specific.virsh.iface_trans.positive_testing.open_rollback_transaction', 'guest-hw.cfg': 'no_glusterfs_support.no_9p_export.smallpages.no_pci_assignable.qcow2.virtio_blk.smp2.virtio_net', 'guest-os.cfg': 'Linux.JeOS.19.x86_64'}

... FAIL type_specific.virsh.iface_trans.positive_testing.open_rollback_transaction -> TestFail: error: Failed to begin network config change transaction error: Requested operation is not valid: failed to begin transaction: Operation invalid in this state - Running '/etc/rc.d/init.d/netcf-transaction change-begin' operation is invalid in this state ...

FAIL type_specific.virsh.iface_trans.negative_testing.no_pending_transaction -> TestFail: 0 not a expected commandreturn value 03:47:20 INFO | 03:47:20 INFO | Virt Test '2013.10.30-200-gf87e', Branch 'next', SHA1 'f87e9d5b1e8e4630c21e05930788815d80435aaa' 03:47:20 INFO | Starting test type_specific.virsh.iface_trans.negative_testing.break_transaction.open_commit_transaction 03:47:20 DEBUG| Test parameters: 03:47:20 DEBUG| _name_map_file = {'tests.cfg': 'libvirt_quick', 'machines.cfg': 'i440fx', 'subtests.cfg': '(subtest=type_specific).(subtest=virsh).(subtest=iface_trans).negative_testing.break_transaction.open_commit_transaction', 'guest-hw.cfg': 'no_glusterfs_support.no_9p_export.smallpages.no_pci_assignable.qcow2.virtio_blk.smp2.virtio_net', 'guest-os.cfg': 'Linux.JeOS.19.x86_64'} 03:47:20 DEBUG| _short_name_map_file = {'tests.cfg': 'libvirt_quick', 'machines.cfg': 'i440fx', 'subtests.cfg': 'type_specific.virsh.iface_trans.negative_testing.break_transaction.open_commit_transaction', 'guest-hw.cfg': 'no_glusterfs_support.no_9p_export.smallpages.no_pci_assignable.qcow2.virtio_blk.smp2.virtio_net', 'guest-os.cfg': 'Linux.JeOS.19.x86_64'}

... Usage: /etc/rc.d/init.d/netcf-transaction {change-begin|change-commit|change-rollback|snapshot-dir|start|stop|status|restart|condrestart|try-restart|reload|force-reload} Usage: /etc/rc.d/rc0.d/K91netcf-transaction {change-begin|change-commit|change-rollback|snapshot-dir|start|stop|status|restart|condrestart|try-restart|reload|force-reload} (again the last one repeated 6 times) There is an open transaction ... FAIL type_specific.virsh.iface_trans.negative_testing.break_transaction.open_commit_transaction -> TestFail: Failed to create snapshot for interface ... Test parameters: 03:47:21 DEBUG| _name_map_file = {'tests.cfg': 'libvirt_quick', 'machines.cfg': 'i440fx', 'subtests.cfg': '(subtest=type_specific).(subtest=virsh).(subtest=iface_trans).negative_testing.break_transaction.open_rollback_transaction', 'guest-hw.cfg': 'no_glusterfs_support.no_9p_export.smallpages.no_pci_assignable.qcow2.virtio_blk.smp2.virtio_net', 'guest-os.cfg': 'Linux.JeOS.19.x86_64'} 03:47:21 DEBUG| _short_name_map_file = {'tests.cfg': 'libvirt_quick', 'machines.cfg': 'i440fx', 'subtests.cfg': 'type_specific.virsh.iface_trans.negative_testing.break_transaction.open_rollback_transaction', 'guest-hw.cfg': 'no_glusterfs_support.no_9p_export.smallpages.no_pci_assignable.qcow2.virtio_blk.smp2.virtio_net', 'guest-os.cfg': 'Linux.JeOS.19.x86_64'}

...

FAIL type_specific.virsh.iface_trans.negative_testing.break_transaction.open_rollback_transaction -> TestFail: error: Failed to begin network config change transaction error: Requested operation is not valid: failed to begin transaction: Operation invalid in this state - Running '/etc/rc.d/init.d/netcf-transaction change-begin' operation is invalid in this state

...

Test parameters: 03:47:22 DEBUG| _name_map_file = {'tests.cfg': 'libvirt_quick', 'machines.cfg': 'i440fx', 'subtests.cfg': '(subtest=type_specific).(subtest=virsh).(subtest=iface_trans).negative_testing.exist_transaction', 'guest-hw.cfg': 'no_glusterfs_support.no_9p_export.smallpages.no_pci_assignable.qcow2.virtio_blk.smp2.virtio_net', 'guest-os.cfg': 'Linux.JeOS.19.x86_64'} 03:47:22 DEBUG| _short_name_map_file = {'tests.cfg': 'libvirt_quick', 'machines.cfg': 'i440fx', 'subtests.cfg': 'type_specific.virsh.iface_trans.negative_testing.exist_transaction', 'guest-hw.cfg': 'no_glusterfs_support.no_9p_export.smallpages.no_pci_assignable.qcow2.virtio_blk.smp2.virtio_net', 'guest-os.cfg': 'Linux.JeOS.19.x86_64'}

cevich commented 10 years ago

Thanks @chuanchang for looking into this. @jferlan is correct, it should throw error.TestNAError (aka SKIP) if environment/setup isn't right.

autotest / virt-test

5 Failures of iface_trans #1019

yum list installed | grep netcf