search

autotest / virt-test

Linux Virtualization Tests
Other
97 stars 140 forks source link

virttest/virt_vm.py: Adjust timing to get mac list #2268

Closed PandaWei closed 9 years ago

PandaWei commented 9 years ago

The fef5c4c move mac_list() to the beginning of get_address(), which leads to verification of arping result failed until the timeout to zero.

The reason as following, The self.virtnet of VM is created by VirtNet.init, and the self.virtnet.mac isn't set any value. So it's better to obtain the mac list after checking the existence of this attribute by nic.has_key('mac').

PandaWei commented 9 years ago

[root@RX300S6-209 virt]# ./run -t libvirt --no-downloads -k --keep-image-between-tests --tests 'type_specific.io-github-autotest-libvirt.virsh.migrate_multi_vms.simultaneous.normal.live' SETUP: PASS (0.00 s) DATA DIR: /var/lib/virt_test DEBUG LOG: /home/autotest_fjtest_v1.6.1_release/client/tests/virt/logs/run-2016-09-07-10.15.30/debug.log TESTS: 4 (1/4) type_specific.io-github-autotest-libvirt.virsh.migrate_multi_vms.simultaneous.normal.live.default.local:PASS (215.73 s) (2/4) type_specific.io-github-autotest-libvirt.virsh.migrate_multi_vms.simultaneous.normal.live.p2p.local:PASS (211.87 s) (3/4) type_specific.io-github-autotest-libvirt.virsh.migrate_multi_vms.simultaneous.normal.live.p2p_tunnelled.local:PASS (208.09 s) (4/4) type_specific.io-github-autotest-libvirt.virsh.migrate_multi_vms.simultaneous.normal.live.direct.local:PASS (75.32 s) TOTAL TIME: 711.79 s (11:51) TESTS PASSED: 4 TESTS FAILED: 0 SUCCESS RATE: 100.00 %

waynesun09 commented 9 years ago

ACK

Hao-Liu commented 9 years ago

LGTM. Ack and Merging.