search

autotest / virt-test

Linux Virtualization Tests
Other
97 stars 140 forks source link

virttest.virsh: Bug fix for event()/qemu_monitor_event() #2271

Closed Chenditang closed 9 years ago

Chenditang commented 9 years ago

In qemu_monitor_event() function, the parameter of timeout should be event_timeout, not event. event() function has the same problem.

PandaWei commented 9 years ago

Code is OK for me. But i noticed that there's no enough information and explanation in your commit(s), including these commits had been merged. Please explain what's the bug in commit log and update this PR.

PandaWei commented 9 years ago

And please notice the length of each line for commit log

PandaWei commented 9 years ago

@Chenditang I means that you should update your commit log, not just only the conversation. Each commit should have detailed log information.

will-Do commented 9 years ago

Fair enough. ACK and merge it