Closed bssrikanth closed 9 years ago
@bssrikanth If you found there's something wrong, Just like CI failed, you don't need to close the old PR and open a new PR. Please update your local codes and push it again, It's enough.
and your PR looks including duplicate commits, Please fix it and push it again. Thanks.
@PandaWei sorry I did not realize that I had 3 commit. I have updated my branch. Please take a look
@Wei,Jiangang Sorry did not realize it. I have now merged multiple commits to single patch. I could not get it pushed to existing branch on github, had to delete existing branch and repush from my system with clean branch. This has closed existing PR. So had to create a new PR #2276
On 07/30/2015 07:05 AM, Wei,Jiangang wrote:
@bassrikanth If you found there's something wrong, Just like CI failed, you don't need to close the old PR and open a new PR. Please update your local codes and push it again, It's enough.
and your PR looks including duplicate commits, Please fix it and push it again. Thanks.
— Reply to this email directly or view it on GitHub https://github.com/autotest/virt-test/pull/2275#issuecomment-126150956.
Currently hostdev addition supported adding only pci type device for passthrough. This commit has added capability to within virt test framework to generate a hostdev xml section for USB device passthrough. Guest VM xml add hostdev will now be able accept USB specific parameters and add respective xml clause to guest VM accordingly.