search

autotest / virt-test

Linux Virtualization Tests
Other
97 stars 140 forks source link

virt-test: test_setup.py: Check 1G hugepage support. #2277

Closed CongLi closed 9 years ago

CongLi commented 9 years ago

Signed-off-by: Cong Li coli@redhat.com

id: 1204060

CongLi commented 9 years ago

Hi @ypu

I have updated the code.

About the 1G hugepage, use "if self.expected_hugepage_size == "1048576" directly. I'm not so sure that I have got all of your meaning.

Could you help review it again and add you comments?

Thanks a lot.

lmr commented 9 years ago

Hi @CongSmile. As you might know, we're moving virt-test to avocado-vt, so I please ask you to consider re-implementing this functionality in the later. The new repo is:

https://github.com/avocado-framework/avocado-vt

Please keep in mind the following guidelines when creating the new PR:

1) Most of the time you can pick the patches of your original PR and merge them on a new branch with minimal changes. 3) Don't use autotest APIs, since we're moving away from using them. Please review the code and change things like utils.system -> process.system, utils.run -> process.run, so on and so forth.

Thanks, and I'm sorry for any inconveniences we might have caused your team.