search

autotest / virt-test

Linux Virtualization Tests
Other
97 stars 139 forks source link

the QemuImg class doesn't have a params attribute, causing failures at postprocess #2287

Closed xutian closed 9 years ago

xutian commented 9 years ago

Signed-off-by: Xu Tian xutian@redhat.com

xutian commented 9 years ago

ID: 1250913

xutian commented 9 years ago

@lmr updated commit by your comment, would you help to review it.

Thanks, Xu

xutian commented 9 years ago

@lmr There so many task need to do in QemuImg class, eg, we need to unify API (eg. backup/remove/restore image) for different image backend (like, ceph, iscsi, nfs and so on). We hope we can reconstruction this class in future. And this fix just a hotfix to make our testing task no blocked by this syntax in QemuImg.info.

Thanks, @xutian

xutian commented 9 years ago

@lmr

For "--backing-chain" option @Chenditang has a special test case to test it. see below PR https://github.com/autotest/tp-qemu/pull/406

lmr commented 9 years ago

Ok, could you please fix the typo and re-submit? Thanks!

xutian commented 9 years ago

Sorry for typo and my poor English. Thanks

xutian commented 9 years ago

@lmr Updated and fixed typo in this PR. thanks

lmr commented 9 years ago

Awesome, approved, thanks!