search

autotest / virt-test

Linux Virtualization Tests
Other
97 stars 140 forks source link

virt-test: base.cfg: some updates for usb cfg. #2292

Closed CongLi closed 9 years ago

CongLi commented 9 years ago
  1. remove "usb_type = ich9-usb-uhci1" which is useless, as "usb_type_usb1 = ich9-usb-uhci1" has defined the usb type.
  2. set "usb_controller = uhci" which can add more devices.

Signed-off-by: Cong Li coli@redhat.com

id: 1183906

CongLi commented 9 years ago

Hi @suqinhuang

I have open a new PR, failed to re-open the previous one.

Could you help review this one?

Thanks.

suqinhuang commented 9 years ago

Acked-by: Suqin Huang

CongLi commented 9 years ago
  1. As xutian said, "usb_type = ich9-usb-uhci1" is the default usb type. Can't remove usb type in case there is no device specified, e.g usb1.
  2. Adding "usb_controller = uhci" means the usb controller is uhci, needs specify usbcontroller*\ if needs add more devices.

Above all, close this PR.

Thanks.

xutian commented 9 years ago

Nacked, if you want to add more device support, you should add configuration to your device, not update default configuration. For USB device, UHCI controller looks too old, set default to EHCI looks more in line with the actual demand.

suqinhuang commented 9 years ago

Discuss with xutian, let's update default controller from uhci to ehci