search

autotest / virt-test

Linux Virtualization Tests
Other
97 stars 140 forks source link

virttest.utils_misc: Report out of memory error in verify_host_dmesg() #2297

Closed spcui closed 9 years ago

spcui commented 9 years ago

Find the out of memory log in host dmesg log.

Signed-off-by: Shuping Cui scui@redhat.com

ID: 1229090

CongLi commented 9 years ago

Hi @spcui

Could you also add the memory info at that time when OOM?

Thanks.

spcui commented 9 years ago

Hi @CongSmile

verify_host_dmesg() invoke by postprocess(), so i think add memory info in here is useless, print the demsg log is ok.

xutian commented 9 years ago

@spcui Any updated for @CongSmile's comments ?

Thanks, Xu

CongLi commented 9 years ago

Hi @spcui

How to make sure the param "dmesg_log_file" is None in your test? param dmesg_log_file is defined in verify_host_dmesg().

Thanks.

spcui commented 9 years ago

hi @CongSmile use it in: virttest/env_process.py:1117: utils_misc.verify_host_dmesg()

CongLi commented 9 years ago

@spcui

Yes, when the dmesg_log_file = None, the host dmesg will save in the debug file. But from the request, no matter dmesg_log_file is None, the host dmesg should be saved in the debug file, right?

Am I misunderstanding?

spcui commented 9 years ago

@CongSmile yes, save to logging.debug file is enough for us.

lmr commented 9 years ago

Hi @spcui. As you might know, we're moving virt-test to avocado-vt, so I please ask you to consider re-implementing this functionality in the later. The new repo is:

https://github.com/avocado-framework/avocado-vt

Please keep in mind the following guidelines when creating the new PR:

1) Most of the time you can pick the patches of your original PR and merge them on a new branch with minimal changes. 3) Don't use autotest APIs, since we're moving away from using them. Please review the code and change things like utils.system -> process.system, utils.run -> process.run, so on and so forth.

Thanks, and I'm sorry for any inconveniences we might have caused your team.