autotest / virt-test

Linux Virtualization Tests
Other
97 stars 139 forks source link

virt-test: utils_test.qemu: Add some func() for windows driver verifier. #2300

Closed CongLi closed 9 years ago

CongLi commented 9 years ago
  1. Enable the windows driver verifier.
  2. Verify the windows driver verifier.
  3. Clear the windows driver verifier.

Signed-off-by: Cong Li coli@redhat.com

id: 1256248

CongLi commented 9 years ago

Hi @vipmike007

Could you help review it?

Thanks.

vipmike007 commented 9 years ago

LGTM.

Ack'ed-By: Mike Cao bcao@redhat.com

CongLi commented 9 years ago

Hi @xutian

Yes, you are right, thanks.

I have updated the code, could you help review it again?

Thanks.

xutian commented 9 years ago

This function should a parts of test steps, so I think it better to move it into utils_test module.

Thanks, Xu

xutian commented 9 years ago

And it should be print steps info in this function like: error.context("enable verifyer in guest OS") , error.context("disable verifyer in guest OS")

CongLi commented 9 years ago

I think it's better to add such context in the test case.

xutian commented 9 years ago

OK, Please move your code to uitls_test.qemu module.

Thanks, Xu

xutian commented 9 years ago

Most of function in this module is host operation, utils_test module is right place to keep test step like functions.

Thanks, Xu

CongLi commented 9 years ago

Ok, have updated it.

Could you help review it again?

Thanks.

xutian commented 9 years ago

LGTM,

Merged, thanks @CongSmile and @vipmike007