Closed CongLi closed 9 years ago
Hi @vipmike007
Could you help review it?
Thanks.
LGTM.
Ack'ed-By: Mike Cao bcao@redhat.com
Hi @xutian
Yes, you are right, thanks.
I have updated the code, could you help review it again?
Thanks.
This function should a parts of test steps, so I think it better to move it into utils_test module.
Thanks, Xu
And it should be print steps info in this function like: error.context("enable verifyer in guest OS") , error.context("disable verifyer in guest OS")
I think it's better to add such context in the test case.
OK, Please move your code to uitls_test.qemu module.
Thanks, Xu
Most of function in this module is host operation, utils_test module is right place to keep test step like functions.
Thanks, Xu
Ok, have updated it.
Could you help review it again?
Thanks.
LGTM,
Merged, thanks @CongSmile and @vipmike007
Signed-off-by: Cong Li coli@redhat.com
id: 1256248