search

autotest / virt-test

Linux Virtualization Tests
Other
97 stars 140 forks source link

Enable Mellanox Connectx PCI SR-IOV [initialization,assignment,cleanup] for IBM PowerKVM #2303

Closed bssrikanth closed 9 years ago

bssrikanth commented 9 years ago

IBM PowerKVM v3.1 (ppc64le) will have support for SR-IOV on Mellanox Connect-x PCI Cards. Currently virt-test test setup supports setup, assign and clean-up of SR-IOV virtual functions on x86 environment. This patch will enable SR-IOV test setup on IBM PowerKVM v3.1 (ppc64le). Existing SR-IOV sanity test cases under qemu can now run on IBM PowerKVM environment. Sample parameter values have also been updated in respective configuration file.

Signed-off-by: Srikanth Aithal sraithal@linux.vnet.ibm.com

xutian commented 9 years ago

@sathnaga Your IDE make value of some configuration to wrong, please reconfigure your IDE then format your patch.

Thanks, Xu

bssrikanth commented 9 years ago

@xutian Will be posting patch again with proper values in guest-hw.cfg.

Srikanth Aithal

xutian commented 9 years ago

Another question, I see you enable ppc and ppcle in OVMF variant, so OVMF is supported by PowerKVM ?

bssrikanth commented 9 years ago

@xutian , no it is not. I am not sure how these changes have happened, I have currently reverted back all unnecessary changes now in guest-hw.cfg. will be reposting soon.

bssrikanth commented 9 years ago

@xutian I have reverted back all unnecessary changes which guest-hw.cfg had. Please review and thanks for your time.

bssrikanth commented 9 years ago

If there are any review comments I will be happy to address them. Many thanks in advance.

lmr commented 9 years ago

Hi @bssrikanth. As you might know, we're moving virt-test to avocado-vt, so I please ask you to consider re-implementing this functionality in the later. The new repo is:

https://github.com/avocado-framework/avocado-vt

Please keep in mind the following guidelines when creating the new PR:

1) Most of the time you can pick the patches of your original PR and merge them on a new branch with minimal changes. 3) Don't use autotest APIs, since we're moving away from using them. Please review the code and change things like utils.system -> process.system, utils.run -> process.run, so on and so forth.

Thanks, and I'm sorry for any inconveniences we might have caused your team.