search

autowarefoundation / AWSIM-Labs

Open source simulator for self-driving vehicles
https://autowarefoundation.github.io/AWSIM-Labs/
Other
13 stars 10 forks source link

Release v1.0.0 #15

Closed xmfcx closed 4 months ago

xmfcx commented 5 months ago

Blocked by

Definition of done

lchojnack commented 4 months ago

I've started to work on this task. During set up I've encountered the issue described here. I think that the issue blocks this task.

xmfcx commented 4 months ago

@lchojnack we have also merged the latest updates to the documentation with:

Updated documentation page: https://autowarefoundation.github.io/AWSIM/main/

We are now waiting for the release, feel free to ask if you have any questions for this task.

lchojnack commented 4 months ago

@xmfcx I've produced the AWSIM binaries and here are my observations

AWSIM binary test

I've tested the binary with Autoware on tag 2024.04.

The binary works well, but I've noticed that green traffic lights are not detected well. I've compared the result with the HDRP version of AWSIM to check if it was caused by the rendering pipeline. I think that changing to URP reduces Autoware traffic light detection performance.

Question: Is the not good green light detection acceptable for this release?

URP (AWSIM Labs) HDRP (AWSIM v.1.2.1)

AWSIM ss2 binary test

I've notice that the AWSIM labs branding are not applicable for ss2 scene.

Question: Is it acceptable for this release or just wait for fix?

AWSIM bin AWSIM ss2 bin
Screenshot_20240418_082037 Screenshot_20240418_082111

Github release

Questions:

xmfcx commented 4 months ago

Thanks @lchojnack

Traffic light problem

Before release, let's wait for this issue to be resolved:

Scenario simulator

For this release, let's keep scenario simulator out, we can do it in the next release.

Permissions

I've added you to the repository with Write permissions, please let me know if it doesn't work for you.

Version

This will be the 1.0.0 for the Autoware Labs.

lchojnack commented 4 months ago

@xmfcx

If the release will be 1.0.0, the version in left-bottom corner of UI shouldn't also point to 1.0.0 instead 1.2.0?

Screenshot_20240418_082037

xmfcx commented 4 months ago

Yes, It should be a part of the release PR, along with the doc updates.

xmfcx commented 4 months ago

I will release the current state with 3 lidars as a beta version 1.0.0-beta along with

To update relevant readme files and instructions.

When

is merged, let's to the 1.0.0 release.

lchojnack commented 4 months ago

@mozhoku @xmfcx I'm trying to release v1.0.0, and I've noticed that the Graphy is missing when I run the AWISM from the main. The Graphy in the videos from https://github.com/autowarefoundation/AWSIM/pull/57 is present.

image

I assume that the Graphy should be visible, and it is a bug on main branch or in my setup.

Could you confirm that it is a bug and Graphy should be visible in the new UI or it is as expected and Graphy shouldn't be visible?

lchojnack commented 4 months ago

@mozhoku @xmfcx Ok, I see what could be wrong. The Graphy is disabled on the scene by default. Please let me know, Is it expected or is it a bug?

image

mozhoku commented 4 months ago

@lchojnack It should be enabled by default. I've forgot to turn it on at some point, my bad. Could you please turn it on? :pray:

lchojnack commented 4 months ago

@mozhoku Thank you for the clarification. Yes, I will enable it.

lchojnack commented 4 months ago

@xmfcx Release v1.0.0 is ready https://github.com/autowarefoundation/AWSIM/releases/tag/v1.0.0

xmfcx commented 4 months ago

@brkay54 could you test this v1.0.0 binary against the latest main branch of the Autoware?

xmfcx commented 4 months ago

Test video with AWSIM Labs 1.0.0: https://www.youtube.com/watch?v=GPow8YPgi1s

Thanks!