github-actions[bot]
commented
5 months ago Documentation URL: https://autowarefoundation.github.io/AWSIM-Labs/pr-90/ Modified URLs:
Closed mitsudome-r closed 4 months ago
github-actions[bot]
commented
5 months ago Documentation URL: https://autowarefoundation.github.io/AWSIM-Labs/pr-90/ Modified URLs:
mitsudome-r
commented
5 months ago NOTE from the discussion with Fatih: We are planning to move this table to Autoware Documentation. There we will have both AWSIM-Labs and TIER IV's AWSIM team to update the table to show the difference between the two.
We can merge this PR once we create the table in Autoware Documentation.
xmfcx
commented
5 months ago You also need to update the README.md section with the new text:
See [Feature differences from the TIER IV/AWSIM in the Autoware Documentation](https://autowarefoundation.github.io/autoware-documentation/main/tutorials/ad-hoc-simulation/digital-twin-simulation/awsim-tutorial/#feature-differences-from-the-awsim-and-awsim-labs).@mozhoku could you take over this task?
xmfcx
commented
4 months ago
Description
The current table makes it look like AWSIM is worse than AWSIM-Labs with a lot of
X, but I don't think it is fair to make such comparisons if you are making modification on top of fork.I would like to modify the documentation to make sure that we're not being disrespectful to upstream developers.
Related links
N/A
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.