ci(pre-commit): only work to already existing files - Githubissues

autowarefoundation / autoware-github-actions

Apache License 2.0

17 stars 24 forks source link

ci(pre-commit): only work to already existing files #291

Closed h-ohta closed 7 months ago

h-ohta commented 7 months ago

Description

The pre-commit should work to already existing files. https://github.com/stefanzweifel/git-auto-commit-action/blob/master/action.yml#L19-L22

Related links

(TIER IV Internal Link) https://tier4.atlassian.net/browse/RT0-31294

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

tkimura4 commented 7 months ago

I confirmed that without this PR, cache files generated by formatter like node_modules/.cache/prettier/.prettier-caches/375c2e8ce79874961ab8e8a179e991bde3f47b7b.json would inadvertently be committed."