autowarefoundation / autoware-github-actions

Apache License 2.0
17 stars 24 forks source link

feat: attach `git diff` in the PR description #323

Closed sasakisasaki closed 1 month ago

sasakisasaki commented 1 month ago

Description

This PR fixes so the version update PR contains the git diff of the target repository. Currently the version update PR contains poor information in its description as this and this makes the review difficult.

Related links

Discussion for feature improvement

Tests performed

After the PR author finishes their tests, this will be updated.

I verified that a PR is created as this. The PR contains the git diff so I believe this is enough as tests.

Notes for reviewers

Currently, the version update PR does not contain git diff and the reviewer needs to go to the target repository by themselves. This PR reduces such the additional task.

Interface changes

No interface changes.

ROS Topic Changes

No ROS topic changes.

ROS Parameter Changes

No ROS parameter changes.

Effects on system behavior

The version update PR will be containing additional information (git diff).

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

sasakisasaki commented 1 month ago

Thank you for your proposals! Now let me do tests again with the fixed one.

sasakisasaki commented 1 month ago

@youtalk @xmfcx Now the version update PR is created as this. Hopefully this is the expected one :+1: .