autowarefoundation / autoware.core

Apache License 2.0
43 stars 26 forks source link

feat(autoware_node): add AutowareNode base class #56

Closed xmfcx closed 2 years ago

xmfcx commented 2 years ago

Signed-off-by: M. Fatih Cırıt mfc@leodrive.ai

Description

This PR is for creating the base class for all the future Autoware Core nodes to inherit from.

This node will be inheriting from the rclcpp_lifecycle::LifecycleNode with (LifeCycle Readme).

While developing this PR, I am going to explore ideas mentioned in previous conversations in the Autoware community.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@3d41dc8). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head b2fac16 differs from pull request most recent head 30d8d48. Consider uploading reports for the commit 30d8d48 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #56 +/- ## ====================================== Coverage ? 0.00% ====================================== Files ? 1 Lines ? 2 Branches ? 0 ====================================== Hits ? 0 Misses ? 2 Partials ? 0 ``` | Flag | Coverage Δ | | |---|---|---| | differential | `0.00% <0.00%> (?)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

xmfcx commented 2 years ago

Changed the branch and switched to https://github.com/autowarefoundation/autoware.core/pull/57