autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
976 stars 636 forks source link

`pid_longitudinal_controller` is missing `autoware_auto_geometry` dependency #3180

Closed VRichardJP closed 1 year ago

VRichardJP commented 1 year ago

Checklist

Description

Compilation fails:

[0/13] Building CXX object CMakeFiles/pid_longitudinal_controller_lib.dir/src/pid_longitudinal_controller.cpp.o
[1/13] Building CXX object CMakeFiles/pid_longitudinal_controller_lib.dir/src/pid_longitudinal_controller.cpp.o
FAILED: CMakeFiles/pid_longitudinal_controller_lib.dir/src/pid_longitudinal_controller.cpp.o 
ccache /usr/bin/c++ -DBOOST_ALLOW_DEPRECATED_HEADERS -DDEFAULT_RMW_IMPLEMENTATION=rmw_fastrtps_cpp -DRCUTILS_ENABLE_FAULT_INJECTION -DROS_DISTRO_HUMBLE -DROS_PACKAGE_NAME=\"pid_longitudinal_controller\" -Dpid_longitudinal_controller_lib_EXPORTS -I/home/sig/autoware/src/universe/autoware.universe/control/pid_longitudinal_controller/include -isystem /usr/include/eigen3 -isystem /home/sig/autoware/install/autoware_auto_vehicle_msgs/include/autoware_auto_vehicle_msgs -isystem /home/sig/autoware/install/autoware_auto_planning_msgs/include/autoware_auto_planning_msgs -isystem /home/sig/autoware/install/tier4_debug_msgs/include/tier4_debug_msgs -isystem /home/sig/autoware/install/autoware_auto_control_msgs/include/autoware_auto_control_msgs -isystem /home/sig/autoware/install/autoware_adapi_v1_msgs/include/autoware_adapi_v1_msgs -isystem /opt/ros/humble/include/diagnostic_msgs -isystem /opt/ros/humble/include -isystem /opt/ros/humble/include/geometry_msgs -isystem /opt/ros/humble/include/rclcpp -isystem /opt/ros/humble/include/rclcpp_components -isystem /opt/ros/humble/include/std_msgs -isystem /opt/ros/humble/include/tf2 -isystem /opt/ros/humble/include/tf2_ros -isystem /home/sig/autoware/install/trajectory_follower_base/include -isystem /home/sig/autoware/install/motion_utils/include -isystem /home/sig/autoware/install/vehicle_info_util/include -isystem /home/sig/autoware/install/interpolation/include -isystem /home/sig/autoware/install/tier4_autoware_utils/include -isystem /home/sig/autoware/install/osqp_interface/include -isystem /home/sig/autoware/install/autoware_auto_perception_msgs/include/autoware_auto_perception_msgs -isystem /opt/ros/humble/include/builtin_interfaces -isystem /opt/ros/humble/include/tf2_geometry_msgs -isystem /opt/ros/humble/include/unique_identifier_msgs -isystem /opt/ros/humble/include/visualization_msgs -isystem /opt/ros/humble/include/rosidl_runtime_c -isystem /opt/ros/humble/include/rcutils -isystem /opt/ros/humble/include/rosidl_typesupport_interface -isystem /opt/ros/humble/include/fastcdr -isystem /opt/ros/humble/include/rosidl_runtime_cpp -isystem /opt/ros/humble/include/rosidl_typesupport_fastrtps_cpp -isystem /opt/ros/humble/include/rmw -isystem /opt/ros/humble/include/rosidl_typesupport_fastrtps_c -isystem /opt/ros/humble/include/rosidl_typesupport_introspection_c -isystem /opt/ros/humble/include/rosidl_typesupport_introspection_cpp -isystem /home/sig/autoware/install/autoware_auto_geometry_msgs/include/autoware_auto_geometry_msgs -isystem /home/sig/autoware/install/autoware_auto_mapping_msgs/include/autoware_auto_mapping_msgs -isystem /opt/ros/humble/include/action_msgs -isystem /opt/ros/humble/include/nav_msgs -isystem /opt/ros/humble/include/ament_index_cpp -isystem /opt/ros/humble/include/libstatistics_collector -isystem /opt/ros/humble/include/rcl -isystem /opt/ros/humble/include/rcl_interfaces -isystem /opt/ros/humble/include/rcl_logging_interface -isystem /opt/ros/humble/include/rcl_yaml_param_parser -isystem /opt/ros/humble/include/libyaml_vendor -isystem /opt/ros/humble/include/tracetools -isystem /opt/ros/humble/include/rcpputils -isystem /opt/ros/humble/include/statistics_msgs -isystem /opt/ros/humble/include/rosgraph_msgs -isystem /opt/ros/humble/include/rosidl_typesupport_cpp -isystem /opt/ros/humble/include/rosidl_typesupport_c -isystem /opt/ros/humble/include/class_loader -isystem /opt/ros/humble/include/composition_interfaces -isystem /opt/ros/humble/include/message_filters -isystem /opt/ros/humble/include/rclcpp_action -isystem /opt/ros/humble/include/rcl_action -isystem /opt/ros/humble/include/tf2_msgs -isystem /opt/ros/humble/include/sensor_msgs -fdiagnostics-color -O2 -g -DNDEBUG -fPIC -Wall -Wextra -Wpedantic -Werror -std=c++17 -MD -MT CMakeFiles/pid_longitudinal_controller_lib.dir/src/pid_longitudinal_controller.cpp.o -MF CMakeFiles/pid_longitudinal_controller_lib.dir/src/pid_longitudinal_controller.cpp.o.d -o CMakeFiles/pid_longitudinal_controller_lib.dir/src/pid_longitudinal_controller.cpp.o -c /home/sig/autoware/src/universe/autoware.universe/control/pid_longitudinal_controller/src/pid_longitudinal_controller.cpp
In file included from /home/sig/autoware/src/universe/autoware.universe/control/pid_longitudinal_controller/include/pid_longitudinal_controller/pid_longitudinal_controller.hpp:22,
                 from /home/sig/autoware/src/universe/autoware.universe/control/pid_longitudinal_controller/src/pid_longitudinal_controller.cpp:15:
/home/sig/autoware/src/universe/autoware.universe/control/pid_longitudinal_controller/include/pid_longitudinal_controller/longitudinal_controller_utils.hpp:20:10: fatal error: geometry/common_2d.hpp: No such file or directory
   20 | #include "geometry/common_2d.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Expected behavior

Can compile

Actual behavior

Compilation fails

Steps to reproduce

Compile?

Versions

No response

Possible causes

No response

Additional context

No response

VRichardJP commented 1 year ago

Fixed by https://github.com/autowarefoundation/autoware.universe/pull/3178