autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
958 stars 624 forks source link

Some improvements and bug fixes on pid_longitudinal_controller after hilly road tests #5121

Open brkay54 opened 12 months ago

brkay54 commented 12 months ago

Checklist

Description

Following PRs are created to fix some unwanted behaviors we observed while testing:

These PRs should be merged in the order. 1- https://github.com/autowarefoundation/autoware.universe/pull/4712 (merged) 2- https://github.com/autowarefoundation/autoware_launch/pull/585 (merged) 3- https://github.com/autowarefoundation/autoware.universe/pull/5077 (closed) 4- https://github.com/autowarefoundation/autoware.universe/pull/5079 5- https://github.com/autowarefoundation/autoware.universe/pull/5080 6- https://github.com/autowarefoundation/autoware.universe/pull/5081

Purpose

Possible approaches

Definition of done

brkay54 commented 12 months ago

cc @TakaHoribe @maxime-clem @takayuki5168 I'd be happy if you could spare your time to review.

pandyah commented 11 months ago

It would be great if it also considers the slope Z value from the PCD file. This will be helpful for vehicles without GNSS/GPS Thanks

brkay54 commented 11 months ago

It would be great if it also considers the slope Z value from the PCD file. This will be helpful for vehicles without GNSS/GPS Thanks

@pandyah You are right, actually, we are planning to handle it by using the ground data from perception. We are planning to improve it. Thank you for the suggestion.

stale[bot] commented 9 months ago

This pull request has been automatically marked as stale because it has not had recent activity.

stale[bot] commented 5 months ago

This pull request has been automatically marked as stale because it has not had recent activity.