autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
893 stars 582 forks source link

ar_tag_based_localizer has flaky test #6619

Closed xmfcx closed 4 months ago

xmfcx commented 4 months ago

Checklist

Description

Fails on multiple build-and-test workflows.

This might be happening because these now run on github public runners with less computing resources.

Expected behavior

Test should pass regardless of the host machine.

Actual behavior

Test occasionally fails.

Steps to reproduce

I could replicate it on my machine too:

Sometimes node doesn't shutdown and I can see it in ros2 node list.

Versions

No response

Possible causes

My diagnosis is: https://github.com/autowarefoundation/autoware.universe/blob/6ee9627bdb009c92139689a960a865dc5ceea28d/localization/landmark_based_localizer/ar_tag_based_localizer/test/test.cpp#L62-L69

The constructor works. But when rclcpp::shutdown(); is called, it sometimes doesn't gracefully exit.

Additional context

No response

xmfcx commented 4 months ago

1: [INFO] [1710387194.546469821] [ar_tag_based_localizer]: Setup of ar_tag_based_localizer node is successful!

but still it times out after a minute

1/1 Test #1: test_ar_tag_based_localizer ......***Timeout 60.06 sec

xmfcx commented 4 months ago

I could replicate it on my machine too:

Sometimes node doesn't shutdown and I can see it in ros2 node list.

You might need to do it multiple times to get it.

xmfcx commented 4 months ago

My diagnosis is: https://github.com/autowarefoundation/autoware.universe/blob/6ee9627bdb009c92139689a960a865dc5ceea28d/localization/landmark_based_localizer/ar_tag_based_localizer/test/test.cpp#L62-L69

The constructor works. But when rclcpp::shutdown(); is called, it sometimes doesn't gracefully exit. @SakodaShintaro