search

autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
968 stars 631 forks source link

obstacle pointcloud based validator node Incorrectly removes the small DetectedObjects (traffic cone) from centerpoint. #6938

Closed sgNicola closed 2 months ago

sgNicola commented 5 months ago

Checklist

Description

The obstacle pointcloud-based validator node is incorrectly removing small DetectedObjects, such as traffic cones, identified by the centerpoint node. This leads to a misdetection. traffic_cone_centerpointtopic validator_topic

Expected behavior

The obstacle pointcloud-based validator node should accurately validate and retain all DetectedObjects recognized by the centerpoint node, including small objects like traffic cones.

Actual behavior

The CenterPoint node detects small objects (e.g., traffic cones) with low frequency, but the obstacle point cloud-based validator node subsequently removes these detections.

Steps to reproduce

  1. Launch Autoware.Universe in an environment with traffic cones as potential obstacles.
  2. Monitor the detection outputs from the centerpoint node and the subsequent validation by the obstacle pointcloud-based validator node.
  3. Observe the failure of the validator node to retain valid DetectedObjects (traffic cones) identified initially by the centerpoint node.

Versions

-OS: Ubuntu20.04 -ROS2: ROS2 galactic -Autoware: Autoware.universe galactic

Possible causes

  1. Low Detection Frequency: The CenterPoint node may not be optimally configured or may lack the sensitivity needed to consistently detect small objects.
  2. Validation Thresholds: The obstacle point cloud-based validator node may have stringent thresholds or criteria that do not favor the retention of small, infrequently detected objects.

Additional context

No response

meliketanrikulu commented 5 months ago

@sgNicola Thanks for your contribution. Could you share example data to reproduce this problem.

sgNicola commented 4 months ago

Hi, I have shared the ros2bag in this Google Drive link [provided.] https://drive.google.com/drive/folders/1CtjPF1jNsm2bRsyisEOX7EJDEtoroJnX?usp=drive_link

meliketanrikulu commented 4 months ago

provided @sgNicola I can not open data link . Could you check the link . Thank you

sgNicola commented 4 months ago

Hi, @meliketanrikulu , I have checked the visiting property, could you please try again? Thank you.

amadeuszsz commented 3 months ago

Hi @sgNicola Did you fix the issue already? If not, I would like to reproduce it but your link does not have rosbag file, I see only the meta file.

sgNicola commented 3 months ago

Thank you for your attention, I have updated the link [ https://drive.google.com/drive/folders/1CtjPF1jNsm2bRsyisEOX7EJDEtoroJnX?usp=sharing]. Could you please check again?

Amadeusz Szymko @.***> 于2024年7月8日周一 14:57写道：

Hi @sgNicola https://github.com/sgNicola Did you fix the issue already? If not, I would like to reproduce it but your link does not have rosbag file, I see only the meta file.

— Reply to this email directly, view it on GitHub https://github.com/autowarefoundation/autoware.universe/issues/6938#issuecomment-2213186742, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3UKP4EV4ZGDCQAW7WTRPB3ZLIZ7HAVCNFSM6AAAAABHMLBCGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJTGE4DMNZUGI . You are receiving this because you were mentioned.Message ID: @.***>

amadeuszsz commented 2 months ago

@sgNicola I reproduced your issue and here is brief summary:

  1. Apart of fact the cone was detected as pedestrian, indeed obstacle_pointcloud_based_validator removes tiny objects.
  2. This issue was addressed in past PR https://github.com/autowarefoundation/autoware.universe/pull/2894. Unfortunately for galactic branch users, this feature is not included.
  3. Beside this dynamic number of points calculation, this detection is still being removed. I believe our default config gives us trade off between maximizing false positives / minimizing true positives removal. Users may play with settings to fit their scenarios. Based on distance and number of points (5~ in your example) I quickly calculated desired values - for your case you would need to change desired class min_points_num to 5 and min_points_and_distance_ratio to 100 here.

obstacle_pointcloud_based_validator

I suggest to move on ROS 2 humble if it's possible and tune the config file, but keep that in mind you will end up with more false positives. I hope it will help you a lot!

sgNicola commented 2 months ago

Thank you for your help!

Amadeusz Szymko @.***> 于2024年7月10日周三 16:43写道：

@sgNicola https://github.com/sgNicola I reproduced your issue and here is brief summary:

  1. Apart of fact the cone was detected as pedestrian, indeed obstacle_pointcloud_based_validator removes tiny objects.
  2. This issue was addressed in past PR #2894 https://github.com/autowarefoundation/autoware.universe/pull/2894. Unfortunately for galactic branch users, this feature is not included.
  3. Beside this dynamic number of points calculation, this detection is still being removed. I believe our default config gives us trade off between maximizing false positives / minimizing true positives removal. Users may play with settings to fit their scenarios. Based on distance and number of points (5~ in your example) I quickly calculated desired values - for your case you would need to change desired class min_points_num to 5 and min_points_and_distance_ratio to 100 here https://github.com/autowarefoundation/autoware_launch/blob/main/autoware_launch/config/perception/object_recognition/detection/detected_object_validation/obstacle_pointcloud_based_validator.param.yaml .

obstacle_pointcloud_based_validator.png (view on web) https://github.com/autowarefoundation/autoware.universe/assets/37396312/4e0e2d84-9e2d-4cc7-a8fa-a9ddc1da3c9b

I suggest to move on ROS 2 humble if it's possible and tune the config file, but keep that in mind you will end up with more false positives. I hope it will help you a lot!

— Reply to this email directly, view it on GitHub https://github.com/autowarefoundation/autoware.universe/issues/6938#issuecomment-2219915922, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3UKP4AJB2DY6BN5YHJ5TNLZLTX3PAVCNFSM6AAAAABHMLBCGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZHEYTKOJSGI . You are receiving this because you were mentioned.Message ID: @.***>

amadeuszsz commented 2 months ago

Thank you for your help!

Closing as resolved 👍🏻