autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
964 stars 630 forks source link

fix(autoware_behavior_velocity_planner_common): remove lane_id check from arc_lane_util #7710

Closed yhisaki closed 3 months ago

yhisaki commented 3 months ago

Description

Currently, when checking the intersection of stop_line and path, it was checked if the lane_id of the intersection is the same as the one specified. However, this check is meaningless and may cause the following error. Therefore, the code to check the lane_id has been removed.

https://tier4.atlassian.net/browse/RT0-30839

How was this PR tested?

https://evaluation.ci.tier4.jp/evaluation/reports/6f5f6e7c-1d11-5ca3-b5cd-f89ac8fca216?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 3 months ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 16.81%. Comparing base (507e3f4) to head (6956b9a). Report is 153 commits behind head on main.

Files Patch % Lines
...avior_velocity_detection_area_module/src/scene.cpp 0.00% 1 Missing :warning:
...topping_area_module/src/scene_no_stopping_area.cpp 0.00% 1 Missing :warning:
...elocity_virtual_traffic_light_module/src/scene.cpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7710 +/- ## =========================================== + Coverage 14.84% 16.81% +1.96% =========================================== Files 1999 486 -1513 Lines 139163 38889 -100274 Branches 43716 10368 -33348 =========================================== - Hits 20661 6539 -14122 + Misses 95731 31473 -64258 + Partials 22771 877 -21894 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/7710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/7710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `16.81% <50.00%> (?)` | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/7710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `?` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.