Closed batuhanbeytekin closed 1 week ago
Thank you for contributing to the Autoware project!
🚧 If your pull request is in progress, switch it to draft mode.
Please ensure:
Attention: Patch coverage is 52.17391%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 28.00%. Comparing base (
fc283c5
) to head (e661cf8
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@batuhanbeytekin It seems like there is a conflict with main branch. Could you resolve the conflicts?
@batuhanbeytekin It seems like there is a conflict with main branch. Could you resolve the conflicts?
Hi @mitsudome-r, my branch is up to date. I think the conflict has been resolved now. Thank you for your reply.
@batuhanbeytekin Can you rebase the commits not related to your PR?
@MasatoSaeki Can you review this PR?
@batuhanbeytekin
If you want to capture progress of main branch, you can use update branch
button. It is easy to do that and. (It looked like you made mistakes when rebase)
And you do not need to assign reviewer who is not related. It only confuses related people.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371
Tests performed
Package built and launch locally.
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.