autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
964 stars 630 forks source link

refactor(detected_object_validation): rework parameters #7750

Closed batuhanbeytekin closed 1 week ago

batuhanbeytekin commented 3 months ago

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371

Tests performed

Package built and launch locally.

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

github-actions[bot] commented 3 months ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

github-actions[bot] commented 2 months ago

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-7750/ Modified URLs:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 28.00%. Comparing base (fc283c5) to head (e661cf8). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t_validation/src/lanelet_filter/lanelet_filter.cpp 0.00% 8 Missing :warning:
...ccupancy_grid_map/occupancy_grid_map_validator.cpp 0.00% 2 Missing :warning:
...tacle_pointcloud/obstacle_pointcloud_validator.cpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7750 +/- ## ========================================== - Coverage 28.00% 28.00% -0.01% ========================================== Files 1317 1317 Lines 98578 98585 +7 Branches 39776 39779 +3 ========================================== Hits 27605 27605 - Misses 70874 70881 +7 Partials 99 99 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/7750/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/7750/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `6.35% <52.17%> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/7750/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `27.99% <ø> (-0.01%)` | :arrow_down: | Carriedforward from [fc283c5](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/fc283c5f8a77d5cce3b63b0c0938ecd90f3a6f63?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mitsudome-r commented 2 months ago

@batuhanbeytekin It seems like there is a conflict with main branch. Could you resolve the conflicts?

batuhanbeytekin commented 2 months ago

@batuhanbeytekin It seems like there is a conflict with main branch. Could you resolve the conflicts?

Hi @mitsudome-r, my branch is up to date. I think the conflict has been resolved now. Thank you for your reply.

Shin-kyoto commented 3 weeks ago

@batuhanbeytekin Can you rebase the commits not related to your PR?

Shin-kyoto commented 3 weeks ago

@MasatoSaeki Can you review this PR?

MasatoSaeki commented 1 week ago

@batuhanbeytekin If you want to capture progress of main branch, you can use update branch button. It is easy to do that and. (It looked like you made mistakes when rebase) And you do not need to assign reviewer who is not related. It only confuses related people. image