autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.01k stars 650 forks source link

feat(start_planner): add skip_rear_vehicle_check parameter #8863

Closed kyoichi-sugahara closed 2 months ago

kyoichi-sugahara commented 2 months ago

Description

launcher PR should be merged first

Add the skip_rear_vehicle_check parameter to the start planner module configuration. This parameter allows disabling the rear vehicle check during collision detection. By default, the rear vehicle check is enabled.

How was this PR tested?

run planning_simulator

default behavior is don't insert stop point from start planner because ego is preventing rear vehicle's progress

      skip_rear_vehicle_check: false

https://github.com/user-attachments/assets/ced3a866-50a5-4ff4-a4dc-a88bcaa30a3b

by changing paramter to true, don't insert stop point

      skip_rear_vehicle_check: true

https://github.com/user-attachments/assets/287daf0d-2ca7-4241-b960-c6f03aeb505a

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 2 months ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 27.79%. Comparing base (aaf5f27) to head (6b5d500). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
..._start_planner_module/src/start_planner_module.cpp 0.00% 3 Missing :warning:
...behavior_path_start_planner_module/src/manager.cpp 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8863 +/- ## ========================================== - Coverage 27.82% 27.79% -0.03% ========================================== Files 1325 1329 +4 Lines 98809 98813 +4 Branches 39667 39649 -18 ========================================== - Hits 27496 27469 -27 - Misses 71281 71294 +13 - Partials 32 50 +18 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8863/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8863/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `0.00% <0.00%> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8863/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `27.81% <ø> (-0.02%)` | :arrow_down: | Carriedforward from [69d3176](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/69d317663c4a96435b4a20366185a64cdae6a758?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.