autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
964 stars 630 forks source link

fix(tier4_localization_rviz_plugin): fix unmatchedSuppression #8919

Closed kobayu858 closed 1 week ago

kobayu858 commented 1 week ago

Description

This is a fix based on cppcheck unmatchedSuppression warnings. Due to a modification to cppcheck's CI, comment suppression is no longer required for items that previously generated warnings.

common/tier4_localization_rviz_plugin/src/pose_history/pose_history_display.cpp:48:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void PoseHistory::onInitialize()
^
common/tier4_localization_rviz_plugin/src/pose_with_covariance_history/pose_with_covariance_history_display.cpp:96:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void PoseWithCovarianceHistory::onEnable()
^
common/tier4_localization_rviz_plugin/src/pose_with_covariance_history/pose_with_covariance_history_display.cpp:102:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void PoseWithCovarianceHistory::onDisable()
^
common/tier4_localization_rviz_plugin/src/pose_with_covariance_history/pose_with_covariance_history_display.cpp:108:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void PoseWithCovarianceHistory::update(float wall_dt, float ros_dt)
^
common/tier4_localization_rviz_plugin/src/pose_with_covariance_history/pose_with_covariance_history_display.cpp:155:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void PoseWithCovarianceHistory::processMessage(
^

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 1 week ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.92%. Comparing base (03ecd6e) to head (ff672be). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8919 +/- ## ========================================== - Coverage 27.98% 27.92% -0.06% ========================================== Files 1319 1319 Lines 98729 98672 -57 Branches 39809 39765 -44 ========================================== - Hits 27631 27558 -73 - Misses 71066 71081 +15 - Partials 32 33 +1 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8919/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8919/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `0.00% <ø> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8919/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `27.93% <ø> (-0.06%)` | :arrow_down: | Carriedforward from [3e377d8](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/3e377d82941fe960a962fde29813cb1f680d51fa?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.