autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
964 stars 630 forks source link

fix(tier4_state_rviz_plugin): fix unmatchedSuppression #8921

Closed kobayu858 closed 6 days ago

kobayu858 commented 1 week ago

Description

This is a fix based on cppcheck unmatchedSuppression warnings. Due to a modification to cppcheck's CI, comment suppression is no longer required for items that previously generated warnings.

common/tier4_state_rviz_plugin/src/custom_button.cpp:67:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomElevatedButton::updateStyle(
^
common/tier4_state_rviz_plugin/src/custom_container.cpp:30:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
QGridLayout * CustomContainer::getLayout() const
^
common/tier4_state_rviz_plugin/src/custom_segmented_button.cpp:44:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
QButtonGroup * CustomSegmentedButton::getButtonGroup() const
^
common/tier4_state_rviz_plugin/src/custom_segmented_button_item.cpp:48:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSegmentedButtonItem::setHovered(bool hovered)
^
common/tier4_state_rviz_plugin/src/custom_segmented_button_item.cpp:55:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSegmentedButtonItem::setCheckableButton(bool checkable)
^
common/tier4_state_rviz_plugin/src/custom_segmented_button_item.cpp:70:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSegmentedButtonItem::setDisabledButton(bool disabled)
^
common/tier4_state_rviz_plugin/src/custom_segmented_button_item.cpp:77:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSegmentedButtonItem::setActivated(bool activated)
^

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 1 week ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.92%. Comparing base (03ecd6e) to head (90da640). Report is 24 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8921 +/- ## ========================================== - Coverage 27.98% 27.92% -0.06% ========================================== Files 1319 1319 Lines 98729 98671 -58 Branches 39809 39762 -47 ========================================== - Hits 27631 27558 -73 - Misses 71066 71080 +14 - Partials 32 33 +1 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8921/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8921/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `0.00% <ø> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8921/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `27.93% <ø> (-0.06%)` | :arrow_down: | Carriedforward from [03ecd6e](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/03ecd6ec6fac24b2832781e68e708c60540589ab?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kobayu858 commented 6 days ago

@h-ohta @isamu-takagi @KhalilSelyan

Please confirm the PR. Thank you very much.