autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.01k stars 650 forks source link

feat(system_error_monitor): remove system error monitor #8929

Closed TetsuKawa closed 1 month ago

TetsuKawa commented 1 month ago

Description

remove system_error_monitor package and relevant parts.

Related links

autoware_launch PR

How was this PR tested?

Comfirmed no problem in launching Psim or Lsim.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 1 month ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.00%. Comparing base (9f7ba86) to head (8deac7e). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...em_rviz_plugin/src/mrm_summary_overlay_display.cpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8929 +/- ## ========================================== - Coverage 28.00% 28.00% -0.01% ========================================== Files 1316 1316 Lines 98601 98607 +6 Branches 39771 39774 +3 ========================================== Hits 27615 27615 - Misses 70840 70846 +6 Partials 146 146 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8929/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8929/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `0.00% <0.00%> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/8929/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `28.00% <ø> (+<0.01%)` | :arrow_up: | Carriedforward from [9f7ba86](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/9f7ba86258dd33f80b03ba6bf297a2fc4e9eb042?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TetsuKawa commented 1 month ago

@kminoda This is the discussion surrounding this PR. system_error_monitor will be replaced by diagnostic_graph_aggregator. It was originally planned to be replaced in June, but it was delayed.