refactor(mrm_emergency_stop_operator): rework parameter - Githubissues

autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/

Apache License 2.0

964 stars 630 forks source link

refactor(mrm_emergency_stop_operator): rework parameter #8937

Open prakash-kannaiah opened 1 week ago

prakash-kannaiah commented 1 week ago

Description

Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the mrm_emergency_stop_operator package.

Remove duplication of parameter declaration between the source code and the parameter file.
Remove the default value from the source code to ensure all parameter values are passed from the parameter files.
Use types that match those returned from declare_parameter() to prevent confusion and potential coding errors.
Move the default parameter file to a standardized location. Use the JSON Schema for that.

Tests performed

No.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guideline.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone with write access can merge the PR.

github-actions[bot] commented 1 week ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.