search

autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.02k stars 652 forks source link

fix(autoware_control_validator): fix clang-diagnostic-unused-private-field #9381

Closed veqcc closed 1 week ago

veqcc commented 1 week ago

Description

Removed unnecessary is_velocity_valid_ variable.

This solves the following clang-tidy error

autoware/src/universe/autoware.universe/control/autoware_control_validator/include/autoware/control_validator/control_validator.hpp:152:8: error: private field 'is_velocity_valid_' is not used [clang-diagnostic-unused-private-field]
  bool is_velocity_valid_{true};
       ^

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 1 week ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.78%. Comparing base (a0c4ab4) to head (580dbb5). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9381 +/- ## ========================================== - Coverage 29.79% 29.78% -0.01% ========================================== Files 1338 1339 +1 Lines 103211 103229 +18 Branches 40212 40213 +1 ========================================== Hits 30748 30748 - Misses 69477 69495 +18 Partials 2986 2986 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9381/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `5.67% <ø> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `29.79% <ø> (ø)` | | Carriedforward from [a0c4ab4](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/a0c4ab45d78f64ef9c7c1022af2c8f61682ae32a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: