search

autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.02k stars 652 forks source link

fix(autoware_obstacle_cruise_planner): fix clang-diagnostic-defaulted-function-deleted #9398

Closed kobayu858 closed 6 days ago

kobayu858 commented 6 days ago

Description

This is a fix based on clang-tidy clang-diagnostic-defaulted-function-deleted error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/autoware_obstacle_cruise_planner/include/autoware/obstacle_cruise_planner/planner_interface.hpp:69:3: error: explicitly defaulted default constructor is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
  PlannerInterface() = default;
  ^

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

kobayu858 commented 6 days ago

There are two ways to fix this: either remove the default constructor or have all member variables have a default constructor. In this case, the default constructor is not used, so it was removed. Confirmed that colcon build does not produce any errors.

github-actions[bot] commented 6 days ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.94%. Comparing base (e901751) to head (b51ecdb). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9398 +/- ## ========================================== - Coverage 29.94% 29.94% -0.01% ========================================== Files 1338 1339 +1 Lines 103359 103379 +20 Branches 40236 40236 ========================================== + Hits 30954 30956 +2 - Misses 69405 69425 +20 + Partials 3000 2998 -2 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9398/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `13.04% <ø> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `29.94% <ø> (ø)` | | Carriedforward from [e901751](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/e9017515ab29571e772b160316ddd259a237353e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: