autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.02k stars 652 forks source link

fix(autoware_behavior_velocity_intersection_module): fix clang-diagnostic-unused-parameter #9409

Closed kobayu858 closed 6 days ago

kobayu858 commented 6 days ago

Description

This is a fix based on clang-tidy clang-diagnostic-unused-parameter error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:493:13: error: unused parameter 'result' [clang-diagnostic-unused-parameter]
  const T & result, const tier4_planning_msgs::msg::PathWithLaneId & path, bool * default_safety,
            ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:493:70: error: unused parameter 'path' [clang-diagnostic-unused-parameter]
  const T & result, const tier4_planning_msgs::msg::PathWithLaneId & path, bool * default_safety,
                                                                     ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:493:83: error: unused parameter 'default_safety' [clang-diagnostic-unused-parameter]
  const T & result, const tier4_planning_msgs::msg::PathWithLaneId & path, bool * default_safety,
                                                                                  ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:494:12: error: unused parameter 'default_distance' [clang-diagnostic-unused-parameter]
  double * default_distance, bool * occlusion_safety, double * occlusion_distance)
           ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:494:37: error: unused parameter 'occlusion_safety' [clang-diagnostic-unused-parameter]
  double * default_distance, bool * occlusion_safety, double * occlusion_distance)
                                    ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:494:64: error: unused parameter 'occlusion_distance' [clang-diagnostic-unused-parameter]
  double * default_distance, bool * occlusion_safety, double * occlusion_distance)
                                                               ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:707:14: error: unused parameter 'rtc_default_approved' [clang-diagnostic-unused-parameter]
  const bool rtc_default_approved, const bool rtc_occlusion_approved, const T & decision_result,
             ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:707:47: error: unused parameter 'rtc_occlusion_approved' [clang-diagnostic-unused-parameter]
  const bool rtc_default_approved, const bool rtc_occlusion_approved, const T & decision_result,
                                              ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:707:81: error: unused parameter 'decision_result' [clang-diagnostic-unused-parameter]
  const bool rtc_default_approved, const bool rtc_occlusion_approved, const T & decision_result,
                                                                                ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:708:44: error: unused parameter 'planner_param' [clang-diagnostic-unused-parameter]
  const IntersectionModule::PlannerParam & planner_param, const double baselink2front,
                                           ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:708:72: error: unused parameter 'baselink2front' [clang-diagnostic-unused-parameter]
  const IntersectionModule::PlannerParam & planner_param, const double baselink2front,
                                                                       ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:709:46: error: unused parameter 'path' [clang-diagnostic-unused-parameter]
  tier4_planning_msgs::msg::PathWithLaneId * path, StopReason * stop_reason,
                                             ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:709:65: error: unused parameter 'stop_reason' [clang-diagnostic-unused-parameter]
  tier4_planning_msgs::msg::PathWithLaneId * path, StopReason * stop_reason,
                                                                ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:710:29: error: unused parameter 'velocity_factor' [clang-diagnostic-unused-parameter]
  VelocityFactorInterface * velocity_factor, IntersectionModule::DebugData * debug_data)
                            ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection.cpp:710:78: error: unused parameter 'debug_data' [clang-diagnostic-unused-parameter]
  VelocityFactorInterface * velocity_factor, IntersectionModule::DebugData * debug_data)
                                                                             ^

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 6 days ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.93%. Comparing base (e901751) to head (05a0dcf). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9409 +/- ## ========================================== - Coverage 29.94% 29.93% -0.02% ========================================== Files 1338 1344 +6 Lines 103359 103413 +54 Branches 40236 40238 +2 ========================================== + Hits 30954 30955 +1 - Misses 69405 69458 +53 Partials 3000 3000 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9409/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9409/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `17.16% <ø> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9409/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `29.94% <ø> (ø)` | | Carriedforward from [e901751](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/e9017515ab29571e772b160316ddd259a237353e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: