search

autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.01k stars 652 forks source link

refactor(goal_planner): rename shoulder_lane to pull_over_lane #9422

Closed kosuke55 closed 4 days ago

kosuke55 commented 4 days ago

Description

This PR is just renaming variables

goal planner supports pull over on road_lane not only shoulder_lane(subtype: road_shoulder). so, pull_over_lane for the variable name. pull_over_lanes means both road_lanes and shoulder_lanes

Related links

Parent Issue:

How was this PR tested?

2024/11/21 https://evaluation.tier4.jp/evaluation/reports/64f8a2e9-8987-5182-add7-7aee9d1b2722/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 4 days ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.95%. Comparing base (d8087f4) to head (0a47c11). Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...r_module/src/pull_over_planner/shift_pull_over.cpp 0.00% 3 Missing :warning:
...s/parking_departure/geometric_parallel_parking.cpp 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9422 +/- ## ========================================== - Coverage 28.96% 28.95% -0.02% ========================================== Files 1427 1433 +6 Lines 108253 108296 +43 Branches 41398 41399 +1 ========================================== Hits 31352 31352 - Misses 73866 73909 +43 Partials 3035 3035 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9422/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9422/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `19.99% <0.00%> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9422/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `28.96% <ø> (+<0.01%)` | :arrow_up: | Carriedforward from [d8087f4](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/d8087f40fdab6d8e289f3374b621aa5228a1e45a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: