autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.01k stars 652 forks source link

fix(autoware_ekf_localizer): publish `processing_time_ms` #9443

Closed SakodaShintaro closed 1 hour ago

SakodaShintaro commented 1 day ago

Description

There is a tool for visualizing processing_time_ms in autoware_tools.

However, autoware_ekf_localizer currently does not publish the required topic. To use the above tools, a node needs to publish a topic with the type tier4_debug_msgs::msg::Float64Stamped and the name processing_time_ms.

Therefore, this pull request adds a processing_time_ms publisher to autoware_ekf_localizer.

How was this PR tested?

system_performance_plotter

ros2 bag record -o /path/to/result_rosbag --use-sim-time -a

and

ros2 run autoware_debug_tools processing_time_plotter \
    -c localization -s --skip_plt_show \
    /path/to/result_rosbag 

The result directory is generated at current directory.

localization_processing_time-24-11-25-14-26-03

Notes for reviewers

None.

Interface changes

Topic changes

Additions and removals

Change type Topic Type Topic Name Message Type Description
Added Pub ~/debug/processing_time_ms tier4_debug_msgs::msg::Float64Stamped The processing time

Effects on system behavior

None.

github-actions[bot] commented 1 day ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.90%. Comparing base (19364ff) to head (098f205). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9443 +/- ## ========================================== - Coverage 29.27% 28.90% -0.38% ========================================== Files 1441 1438 -3 Lines 108617 108109 -508 Branches 41582 41377 -205 ========================================== - Hits 31794 31245 -549 - Misses 73740 73838 +98 + Partials 3083 3026 -57 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9443/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `25.93% <100.00%> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `28.89% <ø> (-0.38%)` | :arrow_down: | Carriedforward from [51f9380](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/51f9380cb5fa3577e85bc2559b8e588524b0a4c6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.