refactor(evaluators, autoware_universe_utils): rename Stat class to Accumulator and move it to autoware_universe_utils

xtk8532704 commented 21 hours ago

Description

Here is a class Stat used across evaluators for accumulating statistics, which is implemented repeatedly in each evaluator. This PR do:

Moved it to autoware_universe_utils/math and remove the implements inside evaluators.
Renamed this class to accumulator (because this class is similar to <boost/accumulators/accumulators.hpp>).

Why do this: This class has been commonly used, and will also be used for other nodes like processing_time_checker for metric statistics, so I do this refactoring.

How was this PR tested?

unit test, psim, evaluator.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 21 hours ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

codecov[bot] commented 19 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.06%. Comparing base (9c6895b) to head (d47a00e). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9459 +/- ## ========================================== + Coverage 29.03% 29.06% +0.02% ========================================== Files 1438 1440 +2 Lines 108432 108441 +9 Branches 41511 41514 +3 ========================================== + Hits 31485 31513 +28 + Misses 73908 73886 -22 - Partials 3039 3042 +3 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9459/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9459/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `31.33% <100.00%> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9459/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `29.00% <ø> (-0.04%)` | :arrow_down: | Carriedforward from [9c6895b](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/9c6895b191163c20726828523b1282e5aed8566a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

autowarefoundation / autoware.universe