autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
958 stars 624 forks source link

motion_velocity_smoother and behavior_velocity_planner should use the same smoother algorithm #987

Open TomohitoAndo opened 2 years ago

TomohitoAndo commented 2 years ago

Checklist

Description

Currently, behavior_velocity_planner uses the smoother to calculate the precise predicted velocity. But smoother algorithm type that behavior_velocity_planner uses is fixed to Analytical, so predicted velocity would be different if the motion_velocity_smoother node uses different smoother algorithm type. So I think the same smoother_type as motion_velocity_smoother should be passed to behavior_velocity_planner.

smoother_type for motion_velocity_smoother is specified here. https://github.com/autowarefoundation/autoware.universe/blob/main/launch/tier4_planning_launch/launch/scenario_planning/scenario_planning.launch.xml#L26-L27

behavior_velocity_planner creates an instance of smoother class (AnalyticalJerkConstrainedSmoother is always created) https://github.com/autowarefoundation/autoware.universe/blob/main/planning/behavior_velocity_planner/src/node.cpp#L305-L310

Purpose

The purpose of this task is to pass the smoother_type parameter to behavior_velocity_planner, and enables motion_velocity_smoother and behavior_velocity_planner to use the same smoother algorithm.

Possible approaches

Definition of done

stale[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity.

stale[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity.