search

autowarefoundation / autoware

Autoware - the world's leading open-source software project for autonomous driving
https://www.autoware.org/
Apache License 2.0
9.16k stars 3.06k forks source link

Remove tier4_ad_api_adaptor #3096

Open isamu-takagi opened 1 year ago

isamu-takagi commented 1 year ago

Checklist

Description

Currently, tier4_ad_api_adaptor is imported as a sample API. However, it is now possible to drive the vehicle even with the newly introduced AD API. It's confusing to have two API examples, so I plan to remove tier4_ad_api_adaptor.

Purpose

Unify API samples to default_ad_api.

Possible approaches

  1. Replace code that uses tier4_ad_api_adaptor with default_ad_api.
  2. Remove tier4_ad_api_adaptor from autoware.repos.

Definition of done

Remove tier4_ad_api_adaptor from autoware.repos

xmfcx commented 1 year ago

Hello @isamu-takagi -san,

https://github.com/autowarefoundation/autoware/blob/c9c4546705bc5a3ef4ebaff0cd151e32b1a5b16b/autoware.repos#L28-L31 Since this comment is present, I guess this issue is still relevant.

Is there a timeline for this issue to be completed? (Is this low priority?)

Could you provide a list of packages to be modified/refactored to achieve this task?

isamu-takagi commented 1 year ago

@xmfcx RTC has not been deleted yet.

This will be completed by migrating to this API. I'm currently implementing this API. https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-interfaces/ad-api/features/cooperation/

xmfcx commented 1 year ago

@isamu-takagi thanks for the information.

I couldn't find Cooperation API in the default_ad_api.

I'm currently implementing this API.

Is it being implemented into the default_ad_api package?

Are there ongoing PRs for this task?

isamu-takagi commented 1 year ago

There are no PRs for AD API yet. I'm currently changing the implementation to match the API.