autowarefoundation / autoware

Autoware - the world's leading open-source software project for autonomous driving
https://www.autoware.org/
Apache License 2.0
9.02k stars 3.02k forks source link

fix: wrong option in setup-dev-env.sh #4039

Closed HansRobo closed 10 months ago

HansRobo commented 10 months ago

Description

install_cuda_drivers, one of extra-vars passed to ansible, is unused now. Alternatively, cuda_install_drivers is used in cuda role. ref: https://github.com/autowarefoundation/autoware/blob/main/ansible/roles/cuda/tasks/main.yaml#L57

Tests performed

In my local test, the command ./setup-dev-env.sh --no-cuda-drivers shows skipping: [localhost] for task autoware.dev_env.cuda : Install cuda-drivers.

Effects on system behavior

Behavor of --no-cuda-drivers option for setup-dev-env.sh

Before ./setup-dev-env.sh : install cuda-drivers ./setup-dev-env.sh --no-cuda-drivers : install cuda-drivers

After ./setup-dev-env.sh : install cuda-drivers ./setup-dev-env.sh --no-cuda-drivers : skip installing cuda-drivers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

xmfcx commented 10 months ago

I think this is from when I renamed the variables.

It seems this variable got away somehow. Sorry for my mistake.